Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: fix regression introduced in #26059 #26643

Closed
wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

In #26059, we introduced a bug that caused 'readable' to be nextTicked
on EOF of a ReadableStream. This breaks the dicer module on CITGM.
That change was partially reverted to still fix the bug in #25810 and
not break dicer.

See: #26059
Fixes: #25810

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

In nodejs#26059, we introduced a bug that caused 'readable' to be nextTicked
on EOF of a ReadableStream. This breaks the dicer module on CITGM.
That change was partially reverted to still fix the bug in nodejs#25810 and
not break dicer.

See: nodejs#26059
Fixes: nodejs#25810
@mcollina mcollina requested review from lpinca and cjihrig March 13, 2019 21:30
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 13, 2019
@mcollina
Copy link
Member Author

This is an alternative to #26617.

@mcollina
Copy link
Member Author

@BridgeAR
Copy link
Member

@mcollina this definitely works with dicer. Do you know something about the failures in readable-stream as well? It seems like the whole test suite currently fails.

@mcollina
Copy link
Member Author

I think there might be two separate regressions that needs to be tracked separately. Or were both caused by #26059?

@BridgeAR
Copy link
Member

@mcollina I do not have any data to verify if it's caused by #26059 as well. We'll have to run another CITGM from before that commit but our CI is currently limited to one at a time and I need one more for v11.12.0, so I'll start it afterwards and post the link here.

@mcollina
Copy link
Member Author

Landed in 269103a

@mcollina mcollina closed this Mar 16, 2019
@mcollina mcollina deleted the fix-dicer branch March 16, 2019 10:58
mcollina added a commit that referenced this pull request Mar 16, 2019
In #26059, we introduced a bug that caused 'readable' to be nextTicked
on EOF of a ReadableStream. This breaks the dicer module on CITGM.
That change was partially reverted to still fix the bug in #25810 and
not break dicer.

See: #26059
Fixes: #25810

PR-URL: #26643
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
In nodejs#26059, we introduced a bug that caused 'readable' to be nextTicked
on EOF of a ReadableStream. This breaks the dicer module on CITGM.
That change was partially reverted to still fix the bug in nodejs#25810 and
not break dicer.

See: nodejs#26059
Fixes: nodejs#25810

PR-URL: nodejs#26643
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
In #26059, we introduced a bug that caused 'readable' to be nextTicked
on EOF of a ReadableStream. This breaks the dicer module on CITGM.
That change was partially reverted to still fix the bug in #25810 and
not break dicer.

See: #26059
Fixes: #25810

PR-URL: #26643
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform stream misses final readable event for small inputs
5 participants