Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimize test-http2-large-file #26737

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 18, 2019

Optimize test-http2-large-file so it only allocates a single buffer.

I don't expect that this will resolve #22327, but one small change at a time....

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Optimize test-http2-large-file so it only allocates a single buffer.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 18, 2019
@Trott
Copy link
Member Author

Trott commented Mar 18, 2019

@Trott
Copy link
Member Author

Trott commented Mar 18, 2019

Again, I don't expect this to fix the test flakiness, but hey, let's check, and let's at least make sure it doesn't make things obviously worse....

Stress test on master using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2165/nodes=win2008r2-vs2017/

Stress test on this PR using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2166/

(The test failures in #22327 only seem to happen on Rackspace + Win 2008 R2, at least recently.)

@Trott Trott added the http2 Issues or PRs related to the http2 subsystem. label Mar 18, 2019
@Trott
Copy link
Member Author

Trott commented Mar 19, 2019

Sorry to ping but I was hoping to get a review or two by now? @nodejs/http2 @nodejs/testing

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2019
Copy link
Member

@edsadr edsadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Mar 20, 2019

Landed in ba1c5ff.

@Trott Trott closed this Mar 20, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 20, 2019
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
@Trott Trott deleted the refactor-test-http2-large-file branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http2-large-file
5 participants