Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: remove usage of require('util') #26822

Closed
wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 20, 2019

Use require('internal/util/inspect').format instead of
require('util').format.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use `require('internal/util/inspect').format` instead of 
`require('util').format`.

Refs: nodejs#26546
@nodejs-github-bot nodejs-github-bot added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Mar 20, 2019
@shisama
Copy link
Contributor

shisama commented Mar 21, 2019

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in a894514 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
MylesBorins pushed a commit that referenced this pull request May 16, 2019
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@dnlup dnlup deleted the util_trace_events branch January 10, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants