console: remove unreachable code #26863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of lib/internal/console/constructor.js includes this
as part of line 470:
setlike ? iterKey : indexKey
However,
setlike
is guaranteed to be true because we are inside of anif
block (starting on line 463) that explicitly checks thatsetlike
is true.
Coverage reporting confirms that
setlike
is always true when it isreached in our tests.
Remove the ternary as the value provided will always be
iterKey
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes