Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: use primordials #26954

Closed
wants to merge 1 commit into from
Closed

esm: use primordials #26954

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Mar 28, 2019 •
edited
Loading

Converted uses of Object and Map to use frozen built
in primordials.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

@MylesBorins
esm: use primordials
369cad4 
Converted uses of Object and Map to use frozen built
in primordials.
@nodejs-github-bot
Copy link
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3081/pipeline

@MylesBorins
Copy link
Contributor Author

Can we fastrack please?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21981/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in 7a54709

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
@MylesBorins @targos
esm: use primordials
7a54709 
Converted uses of Object and Map to use frozen built
in primordials.

PR-URL: #26954
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@MylesBorins @BethGriggs
esm: use primordials
c125aa1 
Converted uses of Object and Map to use frozen built
in primordials.

PR-URL: #26954
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MylesBorins @nodejs-github-bot @targos @guybedford @joyeecheung @devsnek @BridgeAR