net: inline maybeDestroy() #27136
Closed
net: inline maybeDestroy() #27136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`maybeDestroy()` is only called from the listener of the `'end'` event. That event is only emitted after the socket is connected (after `UV_EOF` is read) and after `socket.readable` is set to `false`.
lpinca
force-pushed
the
inline/maybe-destroy
branch
from
6922032
to
767321c
Compare
BridgeAR
approved these changes
Apr 8, 2019
addaleax
approved these changes
Apr 8, 2019
cjihrig
approved these changes
Apr 8, 2019
BridgeAR
added
the
author ready
|
Landed in 655c90b. |
lpinca
added a commit
that referenced
this pull request
Apr 11, 2019
`maybeDestroy()` is only called from the listener of the `'end'` event. That event is only emitted after the socket is connected (after `UV_EOF` is read) and after `socket.readable` is set to `false`. PR-URL: #27136 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybeDestroy()is only called from the listener of the'end'event.That event is only emitted after the socket is connected (after
UV_EOFis read) and after
socket.readableis set tofalse.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes