Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unneeded dependency files #27730

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 16, 2019

The new version of dmn more effectively cleans unneeded dependency
files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it
manually to get the benefits now (and to have a smaller diff when we
update).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 16, 2019
@Trott Trott changed the title tools: remove unneded dependency files tools: remove unneeded dependency files May 16, 2019
The new version of dmn more effectively cleans unneeded dependency
files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it
manually to get the benefits now (and to have a smaller diff when we
update).
@Trott Trott force-pushed the clean-unneeded-eslint-files branch from c6e3590 to ca8f413 Compare May 16, 2019 09:44
@BridgeAR
Copy link
Member

This overlaps with #27670 ;)

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@Trott
Copy link
Member Author

Trott commented May 16, 2019

LGTM if tests pass.

Lite CI should be sufficient since that's the only one that runs the linter. But if you'd prefer a full test suite, either let me know or kick off the full test suite yourself!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 16, 2019
@silverwind
Copy link
Contributor

If only eslint was cleaned, then it should be fine to only run the linter.

@Trott
Copy link
Member Author

Trott commented May 19, 2019

Landed in 7bdd8d6

@Trott Trott closed this May 19, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 19, 2019
The new version of dmn more effectively cleans unneeded dependency
files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it
manually to get the benefits now (and to have a smaller diff when we
update).

PR-URL: nodejs#27730
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 20, 2019
The new version of dmn more effectively cleans unneeded dependency
files. (Thanks, BridgeAR!) It's now in the udpate-*.sh files but run it
manually to get the benefits now (and to have a smaller diff when we
update).

PR-URL: #27730
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
@Trott Trott deleted the clean-unneeded-eslint-files branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants