Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: propagate session destroy code to streams #28435

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 26, 2019

Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the destroy() call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jun 26, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 27, 2019

cc: @nodejs/http2

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What do you think is the correct semver level for this? semver-minor or patch?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 27, 2019

The current behavior definitely seems like a bug to me, but it's also a behavior change. I'd be OK with patch or major.

@jasnell
Copy link
Member

jasnell commented Jun 27, 2019

Hey, sorry I didn't get back on the twitter dm on this @cjihrig... propagating the code is fine, I think, at least for http2 (later, for http3, those semantics will be much more clearly defined).

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24118/

EDIT(cjihrig): CI was green.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a patch.
I would recommend a CITGM run anyway.

cc @jasnell

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 28, 2019

I would recommend a CITGM run anyway.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1891/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 28, 2019

CITGM finished running, if anyone is comfortable interpreting the results.

Currently, when an HTTP2 session is destroyed with a code, that
code is not propagated to the destroy() call of the session's
streams. This commit forwards any code used to destroy a session
to its corresponding streams.

PR-URL: nodejs#28435
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig cjihrig merged commit f963204 into nodejs:master Jun 28, 2019
@cjihrig cjihrig deleted the http2 branch June 28, 2019 19:23
targos pushed a commit that referenced this pull request Jul 2, 2019
Currently, when an HTTP2 session is destroyed with a code, that
code is not propagated to the destroy() call of the session's
streams. This commit forwards any code used to destroy a session
to its corresponding streams.

PR-URL: #28435
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
Currently, when an HTTP2 session is destroyed with a code, that
code is not propagated to the destroy() call of the session's
streams. This commit forwards any code used to destroy a session
to its corresponding streams.

PR-URL: #28435
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants