Fix code example in events API docs #2896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanashworth
added
doc
|
This was actually one of the changes from 0.10. |
| @@ -23,7 +23,7 @@ attached to. | |||
| Use `require('events')` to access the EventEmitter class. | |||
There was a problem hiding this comment.
See this line, directly above. This was changed ages ago. :)
|
Thanks for the contribution though, hopefully you'll find something else to contribute! :) |
|
Sorry, still using v0.10... |
|
Yes we probably should. I feel that would be acceptable |
|
@dgerber yes, would you mind to make a PR for that? :) |
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Sep 16, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Sep 17, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheye
added a commit
that referenced
this pull request
Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
thefourtheye
added a commit
that referenced
this pull request
Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
thefourtheye
added a commit
that referenced
this pull request
Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
thefourtheye
added a commit
that referenced
this pull request
Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.