Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: exitedAfterDisconnect value can be false #29404

Closed
wants to merge 3 commits into from

Conversation

nimit95
Copy link
Contributor

@nimit95 nimit95 commented Sep 2, 2019

Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

Fixes: #28837
Refs: #3743

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

Fixes: nodejs#28837
Refs: nodejs#3743
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Sep 2, 2019
doc/api/cluster.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 3, 2019

Welcome @nimit95 and thanks for the pull request! I left a comment and hope it isn't too much trouble to add the requested details.

@nimit95
Copy link
Contributor Author

nimit95 commented Sep 4, 2019

@Trott thanks for the review, added the requested changes

doc/api/cluster.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 4, 2019

@nodejs/cluster

Co-Authored-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 6, 2019

@nodejs/documentation

@Trott
Copy link
Member

Trott commented Sep 6, 2019

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 6, 2019
@Trott
Copy link
Member

Trott commented Sep 8, 2019

Doesn't strictly need it, but could use another review. @nodejs/collaborators

danbev pushed a commit that referenced this pull request Sep 9, 2019
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danbev
Copy link
Contributor

danbev commented Sep 9, 2019

Landed in 695e819. 🎉

@danbev danbev closed this Sep 9, 2019
@nimit95 nimit95 deleted the patch-1 branch September 14, 2019 07:17
targos pushed a commit that referenced this pull request Sep 20, 2019
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Fixed the documentation to reflect the changes in the default value
of worker.exitedAfterDisconnect

PR-URL: #29404
Fixes: #28837
Refs: #3743
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker.exitedAfterDisconnect is false, after the worker process has exited using process.exit()
6 participants