Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: make StringIO work in ninja.py #29414

Closed
wants to merge 2 commits into from
Closed

gyp: make StringIO work in ninja.py #29414

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 3, 2019

Allow both Python 2 and 3 to access StringIO

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Allow both Python 2 and 3 to access StringIO
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Sep 3, 2019
@targos
Copy link
Member

targos commented Sep 3, 2019

style nit: gyp uses two spaces for indentation

@targos
Copy link
Member

targos commented Sep 3, 2019

👍 if you agree to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 3, 2019
@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor

The commit message should say that this fixes "./configure --ninja", and reference #29371 (comment)

I kicked off a full CI. It has two approvals for fast-track, so can be landed once ci is green.

sam-github pushed a commit that referenced this pull request Sep 3, 2019
Allow both Python 2 and 3 to access StringIO.

This fixes `./configure --ninja`, which was broken by
#29371.

See: #29371 (comment)

PR-URL: #29414
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@sam-github
Copy link
Contributor

Landed in 40060f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants