crypto: use BoringSSL-compatible flag getter #29604
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
HashInit
to return the md flags viaEVP_MD_flags()
instead ofEVP_MD_meth_get_flags()
.In OpenSSL
1.1.1c
, which Node.js bundles at present, these functions are implemented in precisely the same way (see linked implementations above), with the primary difference being thatEVP_MD_flags()
is exposed by BoringSSL whereasEVP_MD_meth_get_flags()
is not.This allows Electron to reduce its patch surface while changing no behavior in Node.js.
cc @tniessen
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes