Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: replace vars in child.js #30383

Closed
wants to merge 2 commits into from
Closed

cluster: replace vars in child.js #30383

wants to merge 2 commits into from

Conversation

EmaSuriano
Copy link
Contributor

@EmaSuriano EmaSuriano commented Nov 12, 2019 •
edited
Loading

Code and Learn walkthrough ... change var to const

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4072/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26613/

lundibundi
lundibundi suggested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ to make sure this doesn't accidentally get merged with other code&learn PRs considering it already has a few approvals, feel free to dismiss as soon as it's fixed.

lib/internal/cluster/child.js Outdated Show resolved Hide resolved
@lundibundi lundibundi removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26669/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27026/

@gireeshpunathil
Copy link
Member

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
@EmaSuriano @gireeshpunathil
cluster: replace vars in child.js
18ce3a3 
PR-URL: #30383
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 18ce3a3

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@EmaSuriano @addaleax
cluster: replace vars in child.js
378c54f 
PR-URL: #30383
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@EmaSuriano @targos
cluster: replace vars in child.js
a31ace5 
PR-URL: #30383
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@EmaSuriano @MylesBorins
cluster: replace vars in child.js
d70ec60 
PR-URL: #30383
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lundibundi lundibundi lundibundi approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@EmaSuriano @BridgeAR @nodejs-github-bot @gireeshpunathil @jasnell @cjihrig @BethGriggs @lundibundi @trivikr