tools: fix build at non-English windows #30492
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25885
There are some non-ASCII characters in v8's code, for example:
node/deps/v8/src/objects/intl-objects.cc
Line 1630 in 04e45db
This causes build failure at non-English windows. This PR adds
/utf-8
compiler option to fix it.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes