Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: remove "this API is unstable" note #30631

Closed
wants to merge 1 commit into from

Conversation

bruce-one
Copy link
Contributor

As #30234 marked this as stable I think this line should be removed as well?

As nodejs#30234 marked this as stable I think this line should be removed as well?
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 24, 2019
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Interesting that the other PR was signed off by no fewer than 9 people and no one noticed. ^^

@gengjiawen
Copy link
Member

Good catch. Interesting that the other PR was signed off by no fewer than 9 people and no one noticed. ^^

Perhaps because the default github diff doesn't show this text.

addaleax pushed a commit that referenced this pull request Nov 27, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@addaleax
Copy link
Member

Landed in 84aa192, thanks for noticing this and opening a PR! 🎉

@addaleax addaleax closed this Nov 27, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants