Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: handle (deep) equal(NaN, NaN) as being identical #30766

Closed
wants to merge 5 commits into from
Closed

assert: handle (deep) equal(NaN, NaN) as being identical #30766

wants to merge 5 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 2, 2019

This aligns the equal and deepEqual() implementation with the
strict version by accepting NaN as being identical in
case both sides are NaN.

Refs: #30350 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: handle (deep) equal(NaN, NaN) as being identical
d5cdde7 
This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.

Refs: nodejs#30350 (comment)
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. util Issues and PRs related to the built-in util module. labels Dec 2, 2019
@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 2, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
lundibundi
lundibundi approved these changes Dec 3, 2019
View reviewed changes
test/parallel/test-assert.js Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27307/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 3, 2019
@Trott
Copy link
Member

Trott commented Dec 5, 2019

This probably requires an update to assert.md since this diverges from the Abstract Equality Comparison cited in the doc?

@Trott
Copy link
Member

Trott commented Dec 5, 2019

This probably requires an update to assert.md since this diverges from the Abstract Equality Comparison cited in the doc?

I mean, I see the YAML is updated, but I think the actual text for assert.equal() in Legacy mode needs to change? And the details for assert.deepEqual() probably need an update too?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27376/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2111/ (seems fine)

@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 6, 2019

@Trott I updated the documentation accordingly.

Trott
Trott reviewed Dec 6, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 6, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Dec 6, 2019
View reviewed changes
doc/api/assert.md Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27419/ ✅ (yellow build with two Windows flakes)

BridgeAR added a commit that referenced this pull request Dec 6, 2019
@BridgeAR
assert: handle (deep) equal(NaN, NaN) as being identical
5360dd1 
This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.

Refs: #30350 (comment)

PR-URL: #30766
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 6, 2019

Landed in 5360dd1 🎉

@BridgeAR BridgeAR closed this Dec 6, 2019
@BridgeAR BridgeAR deleted the align-deep-equal-nan branch January 20, 2020 12:07
@BethGriggs BethGriggs mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @nodejs-github-bot @Trott @jasnell @addaleax @devnexen @lundibundi