Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix common.enoughTestMem #31035

Merged
merged 0 commits into from
Dec 20, 2019
Merged

test: fix common.enoughTestMem #31035

merged 0 commits into from
Dec 20, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 20, 2019

A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be falsy, resulting in a lot of tests being skipped. Fix the typo.

Collaborators, please 👍 to fast-track (or comment if you believe this shouldn't be fast-tracked).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 20, 2019
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. and removed test Issues and PRs related to the tests. labels Dec 20, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Dec 20, 2019

Landed in 118b28a

@Trott Trott closed this Dec 20, 2019
@Trott Trott merged commit 118b28a into nodejs:master Dec 20, 2019
@Trott Trott deleted the fix-mem branch December 20, 2019 18:34
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be false, resulting in a lot of tests being skipped. Fix the typo.

PR-URL: #31035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos pushed a commit that referenced this pull request Jan 14, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be false, resulting in a lot of tests being skipped. Fix the typo.

PR-URL: #31035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be false, resulting in a lot of tests being skipped. Fix the typo.

PR-URL: #31035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants