Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove repetition #31868

Closed
wants to merge 1 commit into from
Closed

doc: remove repetition #31868

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 19, 2020

Merge two similar sentences into one.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca
doc: remove repetition
f9ebd10 
Merge two similar sentences into one.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Feb 19, 2020
mhdawson
mhdawson approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

doc only so the green travis CI should be enough to land.

mhdawson pushed a commit that referenced this pull request Feb 27, 2020
@lpinca @mhdawson
doc: remove repetition
a777cfa 
Merge two similar sentences into one.

PR-URL: #31868
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

Landed in a777cfa

@mhdawson mhdawson closed this Feb 27, 2020
@lpinca lpinca deleted the remove/repetition branch February 29, 2020 07:16
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v13.x. Can you please open a backport if it should be applied to that branch

@lpinca
Copy link
Member Author

lpinca commented Mar 6, 2020

Depends on #31812 which in order depends on a semver-major change. It should not be backported.

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ronag ronag ronag approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @mhdawson @MylesBorins @jasnell @cjihrig @ronag @gireeshpunathil @targos @nodejs-github-bot