Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add method links in events.markdown #3187

Closed
wants to merge 1 commit into from
Closed

doc: add method links in events.markdown #3187

wants to merge 1 commit into from

Conversation

a0viedo
Copy link
Member

@a0viedo a0viedo commented Oct 5, 2015

Added referenced method links.

@mscdex mscdex added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Oct 5, 2015
Many objects in Node.js emit events: a `net.Server` emits an event each time
a peer connects to it, a `fs.readStream` emits an event when the file is
Many objects in Node.js emit events: a [`net.Server`](net.html#net_class_net_server) emits an event each time
a peer connects to it, a [`fs.readStream`](fs.html#net_class_net_server) emits an event when the file is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong hash?

@silverwind
Copy link
Contributor

ping @a0viedo

@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

@a0viedo ... is this still a change you'd like to see made?

@a0viedo
Copy link
Member Author

a0viedo commented Nov 5, 2015

Sorry for leaving this stranded. Updated the reference that @silverwind pointed out.

Also, would love your feedback of future doc changes @jasnell: would be best to group future changes (in different modules) in a single PR?

@silverwind
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

LGTM.

@a0viedo ... I'm happy with it either way, really. I know some prefer to see a fewer number of PRs with more changes, others prefer PRs to be more focused.

Many objects in Node.js emit events: a `net.Server` emits an event each time
a peer connects to it, a `fs.readStream` emits an event when the file is
Many objects in Node.js emit events: a [`net.Server`](net.html#net_class_net_server) emits an event each time
a peer connects to it, a [`fs.readStream`](fs.html#fs_class_fs_readstream) emits an event when the file is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you are editing this line, could you please fix fs.ReadStream (capital R) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Already changed.

@targos
Copy link
Member

targos commented Nov 5, 2015

LGTM with one comment, but that can be taken care of while landing.

Added referenced method links.
targos pushed a commit that referenced this pull request Nov 6, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Nov 6, 2015

Thanks. Landed in d26927c with an edit to fit 80 characters/line.

@targos targos closed this Nov 6, 2015
rvagg pushed a commit that referenced this pull request Nov 7, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
MylesBorins pushed a commit that referenced this pull request Nov 16, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins
Copy link
Contributor

landed in lts-v4.x-staging as 22bfe22

rvagg pushed a commit that referenced this pull request Dec 4, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Added referenced method links.

PR-URL: #3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants