Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename test-lookupService-promises #33100

Closed

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Apr 27, 2020

Rename to test-dns-lookupService-promises to keep naming style consistent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 27, 2020
@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in ab22d2c

@addaleax addaleax closed this May 7, 2020
addaleax pushed a commit that referenced this pull request May 7, 2020
@rickyes rickyes deleted the rename-test-lookupService-promises branch May 8, 2020 00:07
codebytere pushed a commit that referenced this pull request May 11, 2020
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants