Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing deprecation note #33203

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented May 1, 2020

Missing section in deprecation

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels May 1, 2020
ronag added a commit to nxtedition/node that referenced this pull request May 1, 2020
`socket.connect` is subtly broken due to timing and
_undestroy issues. Discourage usage and ask users
to instead create a new socket instance.

Refs: nodejs#33203
@ronag ronag changed the title doc: add missing deprecation not doc: add missing deprecation note May 1, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@juanarbol
Copy link
Member

@ronag CI is not longer required for docs-only changes, it is ok to land with green GitHub actions. :)

ronag added a commit that referenced this pull request May 4, 2020
PR-URL: #33203
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@ronag
Copy link
Member Author

ronag commented May 4, 2020

Landed in 36b4c56

@ronag ronag closed this May 4, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #33203
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos targos mentioned this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants