Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add primordials to arguments comment #33318

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 9, 2020

This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2020
@danbev danbev removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2020
@nodejs-github-bot
Copy link
Collaborator

danbev added a commit that referenced this pull request May 13, 2020
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented May 13, 2020

Landed in e1b90be.

@danbev danbev closed this May 13, 2020
@danbev danbev deleted the add-primordials-command branch May 13, 2020 07:24
codebytere pushed a commit that referenced this pull request May 16, 2020
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.

PR-URL: #33318
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants