lib: always initialize esm loader callbackMap #34127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #34060.
We should instead unilaterally initialize the
callbackMap
and return early if an embedder is choosing to not use the Node.js esm loader is in an embedder context.I also updated the corresponding tests to more directly check
importModuleDynamically
functionality affected by a decision to not use the esm loader provided by Node.js.cc @addaleax @joyeecheung
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes