Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add streams to the pipeline function signature #34153

Closed

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Jul 1, 2020

Adding missing different function signatures

/cc @ronag @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 1, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2020
Comment on lines 1598 to +1599
### `stream.pipeline(source[, ...transforms], destination, callback)`
### `stream.pipeline(streams, callback)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of referencing multiple signatures is just awful, fwiw. Eventually, we really do need to go back and completely rearchitect our doc structure.

jasnell pushed a commit that referenced this pull request Jul 3, 2020
PR-URL: #34153
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

Landed in 7f2cf0f

@jasnell jasnell closed this Jul 3, 2020
@rickyes rickyes deleted the add-pipeline-streams-signature branch July 5, 2020 03:41
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #34153
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
PR-URL: #34153
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere
Copy link
Member

@rickyes does this apply to v12.x?

@rickyes
Copy link
Contributor Author

rickyes commented Sep 28, 2020

@codebytere I don't think it applies to v12.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants