Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: increase API requests allowed when auto closing stalled issues #35235

Closed

Conversation

phillipj
Copy link
Member

The second attempt at getting the auto closing of issues & PRs to work as expected without hitting a maximum operations allowed error we've been seeing.

Recently discovered that the mentioned error is actually self imposed by the stale action itself. It keeps track of how many outgoing GitHub API requests it performs, and if that count exceeds the configured operations-per-run option, it exits to avoid hitting API rate limits.

Default operations-per-run value is set to 30.

That's a very low limit and we're not at all concerned hitting that rate limit as of now, so we're bumping operations-per-run to 500.

Refs #35144

/cc @mmarchini @targos

Checklist

The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs nodejs#35144
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 16, 2020
@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 16, 2020
@mmarchini
Copy link
Contributor

fast track?

mmarchini pushed a commit that referenced this pull request Sep 17, 2020
The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs #35144

PR-URL: #35235
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mmarchini
Copy link
Contributor

mmarchini commented Sep 17, 2020

Landed in c24ad83

@mmarchini mmarchini closed this Sep 17, 2020
@phillipj phillipj deleted the increase-closed-stalled-operations branch September 20, 2020 19:56
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs #35144

PR-URL: #35235
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs #35144

PR-URL: #35235
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
The second attempt at getting the auto closing of issues & PRs to work
as expected without hitting a maximum operations allowed error we've
been seeing.

Recently discovered that the mentioned error is actually self imposed
by the stale action itself. It keeps track of how many outgoing GitHub
API requests it performs, and if that count exceeds the configured
`operations-per-run` option, it exits to avoid hitting API rate limits.

Default `operations-per-run` value is set to `30`.

That's a very low limit and we're not at all concerned hitting that
rate limit as of now, so we're bumping `operations-per-run` to `500`
with these changes.

Refs nodejs#35144

PR-URL: nodejs#35235
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants