-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: disabled manual construction AbortSignal #36094
Closed
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:stop-manual-construction-AbortController
Closed
events: disabled manual construction AbortSignal #36094
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:stop-manual-construction-AbortController
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
force-pushed
the
stop-manual-construction-AbortController
branch
2 times, most recently
from
November 12, 2020 14:35
61e66b6
to
d6a9e3e
Compare
jasnell
approved these changes
Nov 12, 2020
RaisinTen
force-pushed
the
stop-manual-construction-AbortController
branch
3 times, most recently
from
November 13, 2020 17:12
d353925
to
99dd10b
Compare
benjamingr
approved these changes
Nov 13, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 13, 2020
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 13, 2020
aduh95
reviewed
Nov 13, 2020
@@ -35,6 +37,11 @@ function customInspect(self, obj, depth, options) { | |||
} | |||
|
|||
class AbortSignal extends EventTarget { | |||
constructor() { | |||
// eslint-disable-next-line no-restricted-syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why is this comment needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why is this comment needed?
It's because of this:
Lines 22 to 23 in c7d2a45
- selector: "NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError)$/])" | |
message: "Use an error exported by the internal/errors module." |
Trott
reviewed
Nov 14, 2020
RaisinTen
force-pushed
the
stop-manual-construction-AbortController
branch
from
November 14, 2020 05:22
99dd10b
to
ef80268
Compare
lpinca
approved these changes
Nov 14, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 14, 2020
This comment has been minimized.
This comment has been minimized.
himself65
approved these changes
Nov 14, 2020
puzpuzpuz
approved these changes
Nov 14, 2020
Trott
approved these changes
Nov 14, 2020
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 14, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 14, 2020
Landed in 1d02a35...22293ea |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2020
Fixes: #36064 PR-URL: #36094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Fixes: #36064 PR-URL: #36094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
Fixes: nodejs#36064 PR-URL: nodejs#36094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
Fixes: nodejs#36064 PR-URL: nodejs#36094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
Fixes: nodejs#36064 PR-URL: nodejs#36094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
Fixes: #36064 PR-URL: #36094 Backport-PR-URL: #38386 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
added
backported-to-v14.x
events
Issues and PRs related to the events subsystem / EventEmitter.
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-open-v14.x
labels
Apr 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36064
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes