test: more regression tests for minDHSize option #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
crypto
| assert.throws(() => tls.connect({ minDHSize: -1 }), | ||
| /minDHSize is not a positive number/); | ||
|
|
||
| [true, false, null, undefined, {}, [], '', '1'].forEach(value => { |
There was a problem hiding this comment.
Since we are doing this, can we include Infinity and NaN?
There was a problem hiding this comment.
I added tests for negative infinity and nan. I left out positive infinity because I'm not even sure what it would mean to want keys of infinite size.
There was a problem hiding this comment.
I left out positive infinity because I'm not even sure what it would mean to want keys of infinite size.
Infinite quantum entropy?
bnoordhuis
force-pushed
the
more-mindhsize-tests
branch
from
8f66027
to
752e19b
Compare
|
LGTM |
Check that trying to use a < 1024 bits DH key throws an exception. parallel/test-tls-dhe tests this as well but it feels incongruous not to do it here when both tests have similar logic for 1024/2048 bits keys. PR-URL: nodejs#3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: nodejs#3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuis
force-pushed
the
more-mindhsize-tests
branch
from
752e19b
to
82022a7
Compare
bnoordhuis
added a commit
that referenced
this pull request
Nov 7, 2015
Check that trying to use a < 1024 bits DH key throws an exception. parallel/test-tls-dhe tests this as well but it feels incongruous not to do it here when both tests have similar logic for 1024/2048 bits keys. PR-URL: #3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
bnoordhuis
added a commit
that referenced
this pull request
Nov 7, 2015
Check that tls.connect() fails in the expected way when passing in invalid minDHSize options. PR-URL: #3629 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Closed
|
@nodejs/lts ... please weigh in on this one... this LGTM for v4.4 |
|
it is worth noting that this relies on a semver major change from #1831 |
|
yeah, this is not for v4.x cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/658/