Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add issue reference to github pr template #36440

Closed
wants to merge 1 commit into from

Conversation

chinmoy12c
Copy link
Contributor

@chinmoy12c chinmoy12c commented Dec 8, 2020

The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: #36338

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 8, 2020
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect the full URL in the commit message, I think the PR template should be aligned (GitHub UI will show only the issue number anyway).

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
doc/guides/contributing/pull-requests.md Outdated Show resolved Hide resolved
@chinmoy12c
Copy link
Contributor Author

We expect the full URL in the commit message, I think the PR template should be aligned (GitHub UI will show only the issue number anyway).

Thanks for the review, made the changes. :)

The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: nodejs#36338
jasnell pushed a commit that referenced this pull request Dec 16, 2020
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: #36338

PR-URL: #36440
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 16, 2020

Landed in 4a6200e

@jasnell jasnell closed this Dec 16, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: #36338

PR-URL: #36440
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: #36338

PR-URL: #36440
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Add issue reference to the PR template
4 participants