Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enable object-curly-newline in ESLint rules #37040

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 23, 2021

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 23, 2021
doc/api/http2.md Outdated Show resolved Hide resolved
lib/internal/http2/core.js Outdated Show resolved Hide resolved
doc/api/http2.md Outdated Show resolved Hide resolved
lib/internal/encoding.js Outdated Show resolved Hide resolved
lib/internal/http2/core.js Outdated Show resolved Hide resolved
test/node-api/test_threadsafe_function/test.js Outdated Show resolved Hide resolved
test/parallel/test-http2-max-settings.js Outdated Show resolved Hide resolved
test/parallel/test-webcrypto-sign-verify-rsa.js Outdated Show resolved Hide resolved
test/parallel/test-webcrypto-sign-verify-rsa.js Outdated Show resolved Hide resolved
test/parallel/test-webcrypto-wrap-unwrap.js Outdated Show resolved Hide resolved
test/sequential/test-inspector.js Outdated Show resolved Hide resolved
test/sequential/test-stream2-stderr-sync.js Outdated Show resolved Hide resolved
@Trott Trott force-pushed the object-curly-newline branch 2 times, most recently from 8f009db to 79a6948 Compare January 25, 2021 22:29
@Trott
Copy link
Member Author

Trott commented Jan 25, 2021

OK, I think I've added all the suggestions I agree with. Can still be persuaded on the other ones, but for now, PTAL?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: nodejs#37028 (review)

PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 27, 2021

Landed in c5f3565...3e54870

@Trott Trott merged commit 3e54870 into nodejs:master Jan 27, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Feb 2, 2021
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.

Refs: https://eslint.org/docs/rules/object-curly-newline

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
I saw a PR review comment  about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

PR-URL: #37040
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott Trott deleted the object-curly-newline branch September 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants