util: improve typed array formatting #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
util
| @@ -314,6 +315,28 @@ function formatValue(ctx, value, recurseTimes) { | |||
| keys.unshift('size'); | |||
| empty = value.size === 0; | |||
| formatter = formatMap; | |||
| } else if (value instanceof ArrayBuffer) { | |||
There was a problem hiding this comment.
Object.keys((new ArrayBuffer(5))).length === 0. Should this be placed in the shortcut path above?
There was a problem hiding this comment.
nm. overlooked the other keys additions.
There was a problem hiding this comment.
hah. so I wasn't loosing it:
Object.keys(new ArrayBuffer(5)).length === 0;
Object.getOwnPropertyNames(new ArrayBuffer(5)).length === 0;
Object.getOwnPropertySymbols(new ArrayBuffer(5)) === 0;There was a problem hiding this comment.
I put it here because it adds a key for .byteLength but I can probably move it up and call formatProperty() directly, likewise for DataView. Good idea / bad idea?
There was a problem hiding this comment.
Added a fast path for ArrayBuffer, PTAL.
|
LGTM |
Pretty-print typed arrays like regular arrays. Speeds up formatting by almost 300% because it no longer stringifies the array indices. Pretty-print ArrayBuffer and DataView as well by including byteLength, byteOffset and buffer properties in the stringified representation. PR-URL: nodejs#3793 Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
pretty-typed-arrays
branch
from
90fc91b
to
6cf2cff
Compare
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Nov 14, 2015
Pretty-print typed arrays like regular arrays. Speeds up formatting by almost 300% because it no longer stringifies the array indices. Pretty-print ArrayBuffer and DataView as well by including byteLength, byteOffset and buffer properties in the stringified representation. PR-URL: nodejs#3793 Reviewed-By: Trevor Norris <[email protected]>
|
Thanks for review, landed in 34a3591. Apologies, I initially landed it with the wrong Reviewed-By tag. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty-print typed arrays like regular arrays. Speeds up formatting by
almost 300% because it no longer stringifies the array indices.
Pretty-print ArrayBuffer and DataView as well by including byteLength,
byteOffset and buffer properties in the stringified representation.
Taggging this semver-major for now. Maybe overcautious?
CI: https://ci.nodejs.org/job/node-test-pull-request/711/