Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: add JSDoc typings for http #38191

Closed
wants to merge 1 commit into from
Closed

typings: add JSDoc typings for http #38191

wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

Added JSDoc typings for the http lib.

@VoltrexKeyva
lib: add JSDoc typings for http
2d0d5f2 
Added JSDoc typings for the http lib.
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Apr 10, 2021
@targos targos added the typings label Apr 11, 2021
bmeck
bmeck approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@bmeck bmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely want to do this file iteratively for things like the handlers to not make it too hard to read in PR review

@targos targos self-assigned this Apr 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37461/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37467/

@VoltrexKeyva VoltrexKeyva changed the title lib: add JSDoc typings for http typings: add JSDoc typings for http Apr 15, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37493/

targos pushed a commit that referenced this pull request Apr 16, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for http
d3162da 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Apr 16, 2021

Landed in d3162da

@targos targos closed this Apr 16, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-4 branch April 16, 2021 05:50
@VoltrexKeyva VoltrexKeyva mentioned this pull request Apr 17, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for http
60c7591 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@VoltrexKeyva @danielleadams
typings: add JSDoc typings for http
5b5597c 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VoltrexKeyva @nodejs-github-bot @targos @bmeck