Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip ESLint tests if no Intl #41105

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 7, 2021

ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: nodejs#41102
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 7, 2021
@Trott
Copy link
Member Author

Trott commented Dec 7, 2021

Seeking fast-tracking because this fixes CI.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott mentioned this pull request Dec 7, 2021
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
@nodejs-github-bot nodejs-github-bot merged commit e60801a into nodejs:master Dec 7, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in e60801a

danielleadams pushed a commit that referenced this pull request Dec 13, 2021
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: nodejs#41102

PR-URL: nodejs#41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
@Trott Trott deleted the unicode-whoops branch September 25, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI
7 participants