Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add JungMinu to collaborators #4143

Merged
merged 1 commit into from
Dec 4, 2015
Merged

doc: add JungMinu to collaborators #4143

merged 1 commit into from
Dec 4, 2015

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Dec 3, 2015

I will do my very best :)

@JungMinu JungMinu added the doc Issues and PRs related to the documentations. label Dec 3, 2015
@Fishrock123
Copy link
Contributor

LGTM

4 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Dec 3, 2015

LGTM

@zkat
Copy link
Contributor

zkat commented Dec 3, 2015

LGTM

@iarna
Copy link
Member

iarna commented Dec 3, 2015

LGTM

@jasnell
Copy link
Member

jasnell commented Dec 3, 2015

LGTM

@JungMinu JungMinu merged this pull request into master Dec 4, 2015
@JungMinu JungMinu deleted the JungMinu-new-collaborator branch December 4, 2015 00:06
@Fishrock123
Copy link
Contributor

Note: We're going to re-land this as noted in b95e500

JungMinu added a commit that referenced this pull request Dec 4, 2015
@JungMinu
doc: add JungMinu to collaborators
5c6aac4 
PR-URL: #4143
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <http://www.cjihrig.com>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@JungMinu
Copy link
Member Author

JungMinu commented Dec 4, 2015

Landed in 5c6aac4

JungMinu added a commit that referenced this pull request Dec 5, 2015
@JungMinu @rvagg
doc: add JungMinu to collaborators
fd5ed68 
PR-URL: #4143
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <http://www.cjihrig.com>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 8, 2015
Closed
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
JungMinu added a commit that referenced this pull request Dec 29, 2015
@JungMinu
doc: add JungMinu to collaborators
18ac78d 
PR-URL: #4143
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <http://www.cjihrig.com>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@JungMinu
doc: add JungMinu to collaborators
683d8dd 
PR-URL: #4143
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <http://www.cjihrig.com>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@JungMinu
doc: add JungMinu to collaborators
bc6663d 
PR-URL: nodejs#4143
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <http://www.cjihrig.com>
Reviewed-By: Kat Marchán <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JungMinu @Fishrock123 @cjihrig @zkat @iarna @jasnell @MylesBorins