Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: increase maximum line length to 120 characters #41586

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 19, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 19, 2022
@tniessen
Copy link
Member

Alternative: #41509
Alternative: #41536

@tniessen
Copy link
Member

Should this also apply to C++ sources and/or Markdown for consistency? (I'm not saying it's a good idea, but I am curious if the arguments for doing this in JavaScript are really specific to JavaScript.)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott
Copy link
Member Author

Trott commented Jan 19, 2022

Should this also apply to C++ sources and/or Markdown for consistency? (I'm not saying it's a good idea, but I am curious if the arguments for doing this in JavaScript are really specific to JavaScript.)

I'd prefer to treat each one separately so that decisions about one don't get complicated by considerations that only apply in one of the other contexts.

It might also be good to treat this as an experiment. If anyone is hesitant about increasing the limit, then maybe they'd be comfortable with just trying it for a few months and then deciding if we've had to give a lot of line-length nits or not.

But here's my take anyway on C++ and markdown:

  • The last time I programmed C++ on anything more than an occasional as-needed basis was around 20 years ago so I don't have an opinion there.

  • I can go either way with Markdown, but I think I favor eliminating the line breaks there too. All the same IDE (and markdown editor) arguments apply, and the argument that it will greatly simplify diffs applies much more strongly for prose than for code.

@jasnell
Copy link
Member

jasnell commented Jan 19, 2022

Increasing the c++ limit to 120 works for me.

@bnb
Copy link
Contributor

bnb commented Jan 19, 2022

I can go either way with Markdown, but I think I favor eliminating the line breaks there too. All the same IDE (and markdown editor) arguments apply, and the argument that it will greatly simplify diffs applies much more strongly for prose than for code.

Massively favor eliminating line breaks. In general, it seems that the ecosystem has adopted this as a standard, and it's extremely strange for us to be an outlier.

@tniessen
Copy link
Member

Massively favor eliminating line breaks. In general, it seems that the ecosystem has adopted this as a standard, and it's extremely strange for us to be an outlier.

On a side note, I suspect that most of the ecosystem doesn't need to backport documentation changes to multiple release lines with diverging commit histories, so they are probably less concerned about the increased number of conflicts and the reduced usefulness of git operations such as git blame.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 21, 2022
@nodejs-github-bot

This comment has been minimized.

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 870044f into nodejs:master Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 870044f

@Trott Trott deleted the max-len-120 branch January 21, 2022 15:29
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants