Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to V8 4.7.80.25 #4160

Closed
wants to merge 1 commit into from
Closed

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Dec 4, 2015

Pick up the latest patch-level from V8 stable. This includes the following fix:

See also: #4128

R=@nodejs/v8
/cc @vkurchatkin

Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: nodejs#4128
@bnoordhuis
Copy link
Member

LGTM

@ofrobots
Copy link
Contributor Author

ofrobots commented Dec 4, 2015

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Dec 5, 2015
@targos
Copy link
Member

targos commented Dec 5, 2015

LGTM

@ofrobots
Copy link
Contributor Author

ofrobots commented Dec 5, 2015

First CI had failure on windows which passed on the second CI: https://ci.nodejs.org/job/node-test-pull-request/928/.

ofrobots added a commit that referenced this pull request Dec 5, 2015
Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: #4128

PR-URL: #4160
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
@ofrobots
Copy link
Contributor Author

ofrobots commented Dec 5, 2015

Landed in e2dec98.

@rvagg
Copy link
Member

rvagg commented Dec 8, 2015

Applying the label dont-land-on-v5.x — @nodejs/v8 would you mind labeling your PRs with this if it shouldn't got on v5.x but it's technically not semver-major? That way we can strip them out when looking at the differences and what needs to be merged.

@rvagg rvagg mentioned this pull request Dec 17, 2015
@ofrobots ofrobots mentioned this pull request Dec 23, 2015
vkurchatkin added a commit that referenced this pull request Dec 23, 2015
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
vkurchatkin added a commit that referenced this pull request Jan 7, 2016
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: nodejs#4128

PR-URL: nodejs#4160
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants