Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add registry number for Electron 19 #41814

Closed
wants to merge 1 commit into from

Conversation

VerteDinde
Copy link
Contributor

Reserving a new node module version for Electron 19.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 1, 2022
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Fast-track has been requested by @targos. Please 👍 to approve.

@VerteDinde VerteDinde changed the title chore: add registry number for Electron 19 doc: add registry number for Electron 19 Feb 2, 2022
@bnb
Copy link
Contributor

bnb commented Feb 2, 2022

unrelated to the substance of this PR, and absolutely not a blocker: is the history of why we do things like this documented anywhere? I'd really love to have that context :)

@richardlau
Copy link
Member

unrelated to the substance of this PR, and absolutely not a blocker: is the history of why we do things like this documented anywhere? I'd really love to have that context :)

It's all to do with the ABI for addons historically being a single (numerical) identifier and different packagers (Linux distributions) and runtimes (e.g. Electron) have chosen to use different versions of dependencies than we do for the official Node.js binaries. For example several Linux distributions choose to dynamically link against a different OpenSSL version (e.g. #41410); Electron ship different versions of V8.

For more context see

@targos
Copy link
Member

targos commented Feb 3, 2022

Landed in 28989b4

targos pushed a commit that referenced this pull request Feb 3, 2022
PR-URL: #41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@targos targos closed this Feb 3, 2022
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
PR-URL: nodejs#41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@VerteDinde VerteDinde deleted the patch-1 branch February 23, 2022 20:24
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants