Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: copyedit buffer doc #4187

Closed
wants to merge 2 commits into from
Closed

doc: copyedit buffer doc #4187

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 8, 2015

No description provided.

@Trott Trott added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Dec 8, 2015

* `'ascii'` - for 7 bit ASCII data only. This encoding method is very fast, and
will strip the high bit if set.
* `'ascii'` - for 7-bit ASCII data only. This encoding method is very fast,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the comma between "fast" and "and" necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; it is superfluous.

@targos
Copy link
Member

targos commented Dec 8, 2015

LGTM with a question

@Trott
Copy link
Member Author

Trott commented Dec 8, 2015

Revised per @targos question/comment.

@silverwind
Copy link
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2015
PR-URL: nodejs#4187
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 10, 2015

Landed in e47ae58

@Trott Trott closed this Dec 10, 2015
Trott added a commit that referenced this pull request Dec 15, 2015
PR-URL: #4187
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
PR-URL: #4187
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4187
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4187
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott deleted the buffer branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants