Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove extraneous comma #42548

Merged
merged 1 commit into from
Apr 1, 2022
Merged

doc: remove extraneous comma #42548

merged 1 commit into from
Apr 1, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 31, 2022

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Mar 31, 2022
@@ -131,7 +131,7 @@ Node.js process and a cluster worker differs:
port is random the first time, but predictable thereafter. To listen
on a unique port, generate a port number based on the cluster worker ID.

Node.js does not provide routing logic. It is, therefore important to design an
Node.js does not provide routing logic. It is therefore important to design an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Node.js does not provide routing logic. It is therefore important to design an
Node.js does not provide routing logic. It is, therefore, important to design an

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work too but I think it's better without the commas. I will do it that way if you have a strong preference though. As long as there are either two commas or zero commas, I'm good. One comma is Not OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is therefore even necessary language here? Feels like a flourish that can potentially be just dropped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I was just looking for the smallest possible change to fix the issue in the text, so adding a comma or removing a comma were the options I considered. The word therefore is perhaps not necessary, but I think it is valuable as a cue that the recommendation in this sentence is due to the condition explained in the previous sentence. That said, I'm OK with removing it if that's the consensus.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But uh...I see this has sufficient approvals as is, so I'm going to land before we bikeshed any further. 😀

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit fd18b0e into nodejs:master Apr 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in fd18b0e

@Trott Trott deleted the comma branch April 1, 2022 13:56
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
PR-URL: nodejs#42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
This was referenced Apr 5, 2022
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42548
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants