Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move WebAssembly Web API into separate file #42993

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 6, 2022

This moves just the JavaScript part of the WebAssembly Web API implementation into a separate file to avoid bloating pre_execution.js.

Refs: #42960 (comment)

@tniessen tniessen added the wasm Issues and PRs related to WebAssembly. label May 6, 2022
@tniessen tniessen requested a review from joyeecheung May 6, 2022 20:33
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 6, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022
@nodejs-github-bot

This comment was marked as outdated.

lib/internal/wasm_web_api.js Outdated Show resolved Hide resolved
lib/internal/wasm_web_api.js Outdated Show resolved Hide resolved
@tniessen tniessen force-pushed the wasm-web-api-move-js-into-different-file branch from 899de1c to 7184d3d Compare May 6, 2022 21:36
@tniessen
Copy link
Member Author

tniessen commented May 6, 2022

Thanks @aduh95. Rebased, the diff is 899de1c.

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit e8e6d45 into nodejs:master May 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e8e6d45

RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Refs: #42960 (comment)

PR-URL: #42993
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
@juanarbol
Copy link
Member

Backport refs: #42701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. wasm Issues and PRs related to WebAssembly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants