Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 10.2.154.13 #43727

Merged
merged 1 commit into from
Jul 11, 2022
Merged

deps: patch V8 to 10.2.154.13 #43727

merged 1 commit into from
Jul 11, 2022

Conversation

targos
Copy link
Member

@targos targos commented Jul 8, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 8, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2022 •
edited by VoltrexKeyva
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/45168/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4760/

@github-actions github-actions bot mentioned this pull request Jul 9, 2022
Open
21 tasks
bnoordhuis
bnoordhuis approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45205/

@github-actions github-actions bot mentioned this pull request Jul 10, 2022
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45258/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45289/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45309/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit b1f75d7 into main Jul 11, 2022
@nodejs-github-bot nodejs-github-bot deleted the v8-10.2.154.13 branch July 11, 2022 20:38
@nodejs-github-bot
Copy link
Collaborator

Landed in b1f75d7

targos added a commit that referenced this pull request Jul 12, 2022
@targos
deps: patch V8 to 10.2.154.13
d6a9e93 
Refs: v8/v8@10.2.154.4...10.2.154.13

PR-URL: #43727
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@tniessen tniessen tniessen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @bnoordhuis @tniessen @gengjiawen