Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] events: add CustomEvent #44082

Closed
wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 1, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Aug 1, 2022
@aduh95 aduh95 requested a review from targos August 1, 2022 09:34
@targos
Copy link
Member

targos commented Aug 1, 2022

Can you please rebase? I removed a7677bc from staging

This implements the Web API `CustomEvent` in `internal/event_target`.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs#43514
Refs: nodejs#40678
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs#43885
Fixes: nodejs#40678
Refs: nodejs#43514
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
@daeyeon
Copy link
Member

daeyeon commented Aug 2, 2022

@aduh95 Thanks for this backporting.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Aug 2, 2022

Landed in a8c2418...7a5de2c

@targos targos closed this Aug 2, 2022
targos pushed a commit that referenced this pull request Aug 2, 2022
This implements the Web API `CustomEvent` in `internal/event_target`.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43514
Backport-PR-URL: #44082
Refs: #40678
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Aug 2, 2022
Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43885
Backport-PR-URL: #44082
Fixes: #40678
Refs: #43514
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
@aduh95 aduh95 deleted the backport-CustomEvent branch August 2, 2022 08:30
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This implements the Web API `CustomEvent` in `internal/event_target`.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs/node#43514
Backport-PR-URL: nodejs/node#44082
Refs: nodejs/node#40678
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs/node#43885
Backport-PR-URL: nodejs/node#44082
Fixes: nodejs/node#40678
Refs: nodejs/node#43514
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants