module: fix invalid segment deprecation for imports field #44883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the backport requirements for #44477 today I noticed I missed handling the
"imports"
case properly in the runtime deprecation message - this fixes that so that the deprecation message references the"imports"
or"exports"
field properly depending on which is causing the issue (it always logs it as an"exports"
issue even for imports otherwise).I also noticed that the double slash message wasn't being shown when the double slash is part of the pattern match and pattern replacement (invalid module specifier error instead of package target error). I've also made this adjustment as well.
//cc @nodejs/modules