Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add KeyObject Symbol.toStringTag #46043

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

panva
Copy link
Member

@panva panva commented Jan 1, 2023

Same as #46042 but for the Node.js own KeyObject.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jan 1, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2023
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 1, 2023
@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2d59d6b into nodejs:main Jan 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 2d59d6b

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
Notable changes:

* crypto:
  * (SEMVER-MINOR) add CryptoKey Symbol.toStringTag (Filip Skokan) [#46042](#46042)
  * (SEMVER-MINOR) add KeyObject Symbol.toStringTag (Filip Skokan) [#46043](#46043)
* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: TBD
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
Notable changes:

* crypto:
  * (SEMVER-MINOR) add CryptoKey Symbol.toStringTag (Filip Skokan) [#46042](#46042)
  * (SEMVER-MINOR) add KeyObject Symbol.toStringTag (Filip Skokan) [#46043](#46043)
* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: #46286
panva added a commit to panva/node that referenced this pull request Jan 24, 2023
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
panva added a commit to panva/node that referenced this pull request Jan 24, 2023
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#46341
@panva panva added the backport-open-v18.x Indicate that the PR has an open backport. label Jan 24, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 28, 2023
PR-URL: #46043
Backport-PR-URL: #46341
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@panva panva removed the backport-open-v18.x Indicate that the PR has an open backport. label Mar 31, 2023
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
bartlomieju pushed a commit to denoland/deno that referenced this pull request Jul 1, 2024
As per nodejs/node#46043, this adds
Symbol.toStringTag getter to KeyObject.
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants