Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: throw error if options of http.Server is array #46283

Merged
merged 6 commits into from
Jan 25, 2023
Merged

http: throw error if options of http.Server is array #46283

merged 6 commits into from
Jan 25, 2023

Commits on Jan 20, 2023

  1. http: throw error if options of http.Server is array 

    If options of http.Server is array, throw ERR_INVALID_ARG_TYPE.

Refs: nodejs#24176
    @deokjinkim
    deokjinkim committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    59dbe4b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. refactor to use validateObject

    @deokjinkim
    deokjinkim committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    882d62d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. use kEmptyObject for options and apply same change to https.server

    @deokjinkim
    deokjinkim committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    fc78793 View commit details
    Browse the repository at this point in the history

  2. fixup! pass ommited noDelay option in https

    @deokjinkim
    deokjinkim committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    548bdf5 View commit details
    Browse the repository at this point in the history

  3. remove overwriting options 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @deokjinkim @aduh95
    deokjinkim and aduh95 authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    141501d View commit details
    Browse the repository at this point in the history

  4. fixup! lint error

    @deokjinkim
    deokjinkim committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a41a496 View commit details
    Browse the repository at this point in the history