Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: add trailing commas in source files #46714

Merged
merged 1 commit into from
Feb 22, 2023
Merged

debugger: add trailing commas in source files #46714

merged 1 commit into from
Feb 22, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 18, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Feb 18, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 18, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46714
✔  Done loading data for nodejs/node/pull/46714
----------------------------------- PR info ------------------------------------
Title      debugger: add trailing commas in source files (#46714)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:dangle-debugger -> nodejs:main
Labels     author ready, debugger
Commits    1
 - debugger: add trailing commas in source files
Committers 1
 - Antoine du Hamel 
PR-URL: https:/nodejs/node/pull/46714
Reviewed-By: Kohei Ueno 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Darshan Sen 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https:/nodejs/node/pull/46714
Reviewed-By: Kohei Ueno 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Darshan Sen 
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 Feb 2023 11:17:39 GMT
   ✔  Approvals: 5
   ✔  - Kohei Ueno (@cola119): https:/nodejs/node/pull/46714#pullrequestreview-1304591415
   ✔  - Debadree Chatterjee (@debadree25): https:/nodejs/node/pull/46714#pullrequestreview-1304592916
   ✔  - Darshan Sen (@RaisinTen) (TSC): https:/nodejs/node/pull/46714#pullrequestreview-1304593263
   ✔  - Moshe Atlow (@MoLow): https:/nodejs/node/pull/46714#pullrequestreview-1304613663
   ✔  - James M Snell (@jasnell) (TSC): https:/nodejs/node/pull/46714#pullrequestreview-1304927164
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https:/nodejs/node/actions/runs/4236040765

@aduh95
debugger: add trailing commas in source files
655b070 
PR-URL: nodejs#46714
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 22, 2023

Landed in 655b070

@aduh95 aduh95 merged commit 655b070 into nodejs:main Feb 22, 2023
@aduh95 aduh95 deleted the dangle-debugger branch February 22, 2023 00:28
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
debugger: add trailing commas in source files
83b529f 
PR-URL: #46714
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
debugger: add trailing commas in source files
44375c6 
PR-URL: #46714
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MoLow MoLow MoLow approved these changes

@debadree25 debadree25 debadree25 approved these changes

@cola119 cola119 cola119 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. debugger Issues and PRs related to the debugger subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @jasnell @MoLow @debadree25 @cola119 @RaisinTen