Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove use of SSL_OP_SINGLE_DH_USE #46955

Closed
wants to merge 0 commits into from
Closed

src: remove use of SSL_OP_SINGLE_DH_USE #46955

wants to merge 0 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 4, 2023

This option does not have any effect in any supported OpenSSL version.

Refs: #46954

@tniessen tniessen added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 4, 2023
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50201/

@tniessen tniessen added the tls Issues and PRs related to the tls subsystem. label Mar 4, 2023
bnoordhuis
bnoordhuis approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: SSL_OP_SINGLE_DH_USE is always zero nowadays, i.e., a no-op.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50206/

tniessen added a commit that referenced this pull request Mar 9, 2023
@tniessen
src: remove use of SSL_OP_SINGLE_DH_USE
ef454c8 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@tniessen tniessen closed this Mar 9, 2023
@tniessen tniessen force-pushed the src-remove-SSL_OP_SINGLE_DH_USE branch from 1332e1e to ef454c8 Compare March 9, 2023 11:26
@tniessen tniessen deleted the src-remove-SSL_OP_SINGLE_DH_USE branch March 9, 2023 11:27
@tniessen
Copy link
Member Author

tniessen commented Mar 9, 2023

Landed in ef454c8.

targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen @targos
src: remove use of SSL_OP_SINGLE_DH_USE
9b7d39f 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@tniessen @targos
src: remove use of SSL_OP_SINGLE_DH_USE
b051ac7 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
src: remove use of SSL_OP_SINGLE_DH_USE
a4a433f 
This option does not have any effect in any supported OpenSSL version.

Refs: #46954
PR-URL: #46955
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @panva @bnoordhuis @cjihrig