lib: Remove unnecessary TODO comments #4719
Conversation
|
LGTM The mentor who is available is probably @Fishrock123. (I'm inferring this from the fact that he's the one that added the |
Original committer stated they were safe to remove in issue post. Ref: Issue nodejs#4642
pgeiss
force-pushed
the
remove_unnecessary_TODO
branch
from
a68df69
to
22f28a2
Compare
|
Rebased on latest master. |
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Thanks! Landed in 83d2b77. A full CI run isn't necessary for removing a few comments, but I did run the tests locally as a sanity check. |
|
Thanks for finding a place to contribute @pgeiss, it looks like this is your first commit in core, if so, welcome on board! I hope you can find other places to make an impact. |
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Original committer (@trevnorris) stated they were safe to remove in issue comments.
Ref: Issue #4642
PS: I want to work more on the TODOs in 4642 (and, you know, actually fix things). I'm assuming I should direct questions if I have any there? It has a 'mentor-available' tag.