Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary status check on test-release-npm #47516

Closed
wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

test-release-npm is failing on #47381 and it seems related to #43716. However, this asserting seems unnecesary, so rather than adjust it (either on npm side or node.js) sounds reasonable to remove that check.

However, it doesn't mean there's no bug in that change. It seems process.exitCode isn't considered when process.exit() is called with undefined. cc: @daeyeon

@RafaelGSS RafaelGSS requested a review from targos April 11, 2023 21:06
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 11, 2023
@richardlau
Copy link
Member

cc @nodejs/npm

Copy link

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that in light of #43716 this is an unnecessary check.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS
Copy link
Member Author

I'm requesting fast-track because I need to include it on v20.0.0 and run the CI/release candidate and so on.

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2023
@RafaelGSS
Copy link
Member Author

The GitHub UI shows a pending CI, but the CI link shows it as finished. Should I land it manually? @nodejs/build

@RafaelGSS RafaelGSS marked this pull request as draft April 12, 2023 21:41
@RafaelGSS RafaelGSS marked this pull request as ready for review April 12, 2023 21:41
@Trott
Copy link
Member

Trott commented Apr 12, 2023

The GitHub UI shows a pending CI, but the CI link shows it as finished. Should I land it manually? @nodejs/build

Yes, if you are reasonably certain that the GitHub widget is showing bad information and CI is in fact complete and successful, you can always land manually.

@RafaelGSS
Copy link
Member Author

Landed in e67b944

RafaelGSS added a commit that referenced this pull request Apr 13, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS closed this Apr 13, 2023
RafaelGSS added a commit that referenced this pull request Apr 13, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS added a commit that referenced this pull request Apr 13, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS added a commit that referenced this pull request Apr 13, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: nodejs#47516
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants