Add the missing LoongArch64 definition in the v8.gyp file. #47641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
targos
approved these changes
Apr 20, 2023
anonrig
approved these changes
Apr 20, 2023
richardlau
approved these changes
Apr 20, 2023
VoltrexKeyva
approved these changes
Apr 20, 2023
lpinca
approved these changes
Apr 20, 2023
|
Modify the title, because the check failed due to the original title being too long. |
gengjiawen
approved these changes
Apr 21, 2023
github-actions
bot
removed
the
request-ci
|
Modify the title again, because the title check failed. |
|
Hey @sunhaiyong1978, it seems like your commit has an invalid user (basically doesn't point to you), make sure you've configured Git with the appropriate details so that you would be shown as a contributor after this gets merged. This is generally the cause of the incorrect email being used, make sure it is set to the primary email of your GitHub account by running the following: $ git config --global user.email "<The primary email>"(Replace And then do a force-push. |
|
Okay, I have modified my submission email. |
39 tasks
aymen94
approved these changes
Apr 24, 2023
This was referenced Apr 25, 2023
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
35 tasks
|
I received 3 failing checks , but it seems that they are not caused by the pull request I submitted. What should I do next? |
This was referenced Apr 28, 2023
|
Landed in aa6600d |
targos
pushed a commit
that referenced
this pull request
May 1, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
32 tasks
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47641 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
danielleadams
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tools/v8_gypfiles/v8.gyp file, there is a missing definition for the LoongArch64 architecture (defined as loong64 in v8). This can lead to errors when compiling node.js that supports v8 on the LoongArch64 architecture.