Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add getCWDURL internal util fn #48434

Merged
merged 9 commits into from
Sep 22, 2023
Merged

util: add getCWDURL internal util fn #48434

merged 9 commits into from
Sep 22, 2023

Commits on Sep 20, 2023

  1. util: add getCwdSafe internal util fn 

    This function was first implemented in nodejs#46826, but at some point
of the PR implementation this fn was no longer related to the PR.

Refs: nodejs#46826 (comment)
    @jlenon7
    jlenon7 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    17aa7a7 View commit details
    Browse the repository at this point in the history

  2. util: use in other scenarios of internal/modules 

    Use `getCwdSafe` in other scenarios of `internal/modules` package.
    @jlenon7
    jlenon7 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5bd32a9 View commit details
    Browse the repository at this point in the history

  3. test: fix lines of .snapshot of loader module 

    Increment the line number in `.snapshot` file since we have add
the `require()` instruction of `getCwdSafe` in
`internal/modules/cjs/loader.js` file.
    @jlenon7
    jlenon7 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ad89e01 View commit details
    Browse the repository at this point in the history

  4. util: move from getCwdSafe to getCWDURL 

    Implement a function that can handle a second
cachedCWD when Node.js process doesn't owns it
own state.
    @jlenon7
    jlenon7 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    269f624 View commit details
    Browse the repository at this point in the history

  5. fix: lint

    @jlenon7
    jlenon7 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bbede9b View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Update lib/internal/util.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8df6eae View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/util.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b0871b0 View commit details
    Browse the repository at this point in the history

  3. Update lib/internal/util.js 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @jlenon7 @aduh95
    jlenon7 and aduh95 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    22d6cfc View commit details
    Browse the repository at this point in the history

  4. fix: remove entry_point.c file

    @jlenon7
    jlenon7 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    61b8d8b View commit details
    Browse the repository at this point in the history